-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Fix reindex yaml test #126942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
parkertimmins
merged 1 commit into
elastic:main
from
parkertimmins:parker/fix-reindex-yaml-test-race-condition
Apr 16, 2025
Merged
Fix reindex yaml test #126942
parkertimmins
merged 1 commit into
elastic:main
from
parkertimmins:parker/fix-reindex-yaml-test-race-condition
Apr 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reindex task may not have completed by time status is called, so remove assertion that relies on this. Following assertions are set in the action which starts task, so will be correct whether or not task has completed.
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
approved these changes
Apr 16, 2025
This was referenced Apr 16, 2025
parkertimmins
added a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Apr 16, 2025
Reindex task may not have completed by time status is called, so remove assertion that relies on this. Following assertions are set in the action which starts task, so will be correct whether or not task has completed.
parkertimmins
added a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Apr 16, 2025
Reindex task may not have completed by time status is called, so remove assertion that relies on this. Following assertions are set in the action which starts task, so will be correct whether or not task has completed.
parkertimmins
added a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Apr 16, 2025
Reindex task may not have completed by time status is called, so remove assertion that relies on this. Following assertions are set in the action which starts task, so will be correct whether or not task has completed.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 16, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 16, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 16, 2025
* Fix reindex yaml test (#126942) Reindex task may not have completed by time status is called, so remove assertion that relies on this. Following assertions are set in the action which starts task, so will be correct whether or not task has completed. * unmute test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Data Management/Data streams
Data streams and their lifecycles
>non-issue
Team:Data Management
Meta label for data/management team
v8.18.1
v8.19.0
v9.0.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reindex task may not have completed by time status is called, so remove assertion that relies on this. Following assertions are set in the action which starts task, so will be correct whether or not task has completed.
Fixes #126769